Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit, add isort and fix imports #77

Merged
merged 8 commits into from
Jun 15, 2020
Merged

Update pre-commit, add isort and fix imports #77

merged 8 commits into from
Jun 15, 2020
+118 −138

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Jun 13, 2020 •
edited
Loading

  • updated pre-commit
  • added isort to pre-commit and tox (config compatible with black)
  • fixed imports
  • fixed some docstrings to comply with pydocstring
  • added some missing asserts in tests

Better reviewed commit by commit.

@amureki amureki self-assigned this Jun 13, 2020
@amureki amureki marked this pull request as ready for review June 13, 2020 10:38
@amureki amureki added the enhancement New feature or request label Jun 13, 2020
@amureki amureki assigned berinhard and anapaulagomes and unassigned amureki Jun 13, 2020
anapaulagomes
anapaulagomes suggested changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Rust! 🌷 I just suggested a few minor things.

setup.cfg

[isort]
multi_line_output=3
include_trailing_comma=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took config from black docs :)
https://black.readthedocs.io/en/stable/the_black_code_style.html#how-black-wraps-lines

tests/test_filling_fields.py Outdated Show resolved Hide resolved
tests/test_filling_fields.py Outdated Show resolved Hide resolved
berinhard
berinhard approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@berinhard berinhard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for me! I only agreed with @anapaulagomes suggestions as well 👍

Rust Saiargaliev and others added 3 commits June 14, 2020 23:16
@anapaulagomes
Update tests/test_filling_fields.py
dac6fa2 
Co-authored-by: Ana Paula Gomes <[email protected]>
@anapaulagomes
Update tests/test_filling_fields.py
6ac1ce2 
Co-authored-by: Ana Paula Gomes <[email protected]>
Merge remote-tracking branch 'origin/master' into cleanups_imports_etc
f965a8e 
* origin/master:
  Enable seq to be imported from baker (#76)
@amureki amureki requested a review from anapaulagomes June 14, 2020 22:00
anapaulagomes
anapaulagomes approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amureki
Copy link
Collaborator Author

amureki commented Jun 15, 2020

@anapaulagomes @berinhard thanks for the reviews! 🏅

@amureki amureki merged commit b6087e0 into master Jun 15, 2020
@amureki amureki deleted the cleanups_imports_etc branch June 15, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anapaulagomes anapaulagomes anapaulagomes approved these changes

@berinhard berinhard berinhard approved these changes

Assignees

@berinhard berinhard

@anapaulagomes anapaulagomes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amureki @berinhard @anapaulagomes